RFR: JDK-8312418: Add Elements.getEnumConstantBody [v2]
Joe Darcy
darcy at openjdk.org
Thu Aug 24 17:22:28 UTC 2023
On Wed, 23 Aug 2023 14:01:53 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update printing processor.
>
> src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 772:
>
>> 770: *
>> 771: * @throws IllegalArgumentException if the argument is not an {@code enum} constant
>> 772: * @param enumConstant an enum constant
>
> nice, my only comment is that the order selected in the javadoc seems to be at odds with the rest of the javadoc in this class. The common order I see is:
>
> 1. @implSpec
> 2. @param
> 3. @return
> 4. @throws
Tags reordered; thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14939#discussion_r1304644457
More information about the compiler-dev
mailing list