RFR: 8306914: Implement JEP 458: Launch Multi-File Source-Code Programs [v11]

Christian Stein cstein at openjdk.org
Mon Dec 4 08:57:47 UTC 2023


On Mon, 4 Dec 2023 08:34:29 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update tests
>
> test/jdk/java/util/stream/GathererTest.java line 352:
> 
>> 350:     @MethodSource("configurations")
>> 351:     public void testMassivelyComposedGatherers(Config config) {
>> 352:         final int ITERATIONS = 128; // Total number of compositions is 1 + (iterations*2)
> 
> Sorry, but I think it is not appropriate to do a change like this here. It should have its own PR and discussion.

Yes, I will revert this change and let @viktorklang-ora fine-tune it in another PR.

> test/langtools/tools/javac/launcher/src/p/q/CLTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
> 
> Probably:
> Suggestion:
> 
>  * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> (not sure, but the file existed before, it is just moved, AFAIK.)

Yes. It was moved from `.../launcher/src` to `.../launcher/p/q`, thus committing as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13712#discussion_r1413543215
PR Review Comment: https://git.openjdk.org/jdk/pull/13712#discussion_r1413549502


More information about the compiler-dev mailing list