RFR: 8306914: Implement JEP 458: Launch Multi-File Source-Code Programs [v11]

Alan Bateman alanb at openjdk.org
Mon Dec 4 09:12:46 UTC 2023

On Mon, 4 Dec 2023 08:49:06 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> test/jdk/java/util/stream/GathererTest.java line 352:
>>> 350:     @MethodSource("configurations")
>>> 351:     public void testMassivelyComposedGatherers(Config config) {
>>> 352:         final int ITERATIONS = 128; // Total number of compositions is 1 + (iterations*2)
>> Sorry, but I think it is not appropriate to do a change like this here. It should have its own PR and discussion.
> Yes, I will revert this change and let @viktorklang-ora fine-tune it in another PR.

Viktor has the change in JDK-8321124 to dial it down. Right now it requires too much stack on x86_32 systems used in the GHA testing.


PR Review Comment: https://git.openjdk.org/jdk/pull/13712#discussion_r1413568646

More information about the compiler-dev mailing list