RFR: 8320144: Compilation crashes when a custom annotation with invalid default value is used [v4]

Jan Lahoda jlahoda at openjdk.org
Wed Dec 6 11:43:37 UTC 2023

On Wed, 6 Dec 2023 11:40:47 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> The erroneous case of:
>> `public String[] excludeModules() default new String[0];`
>> was not short-circuited in the compiler and we were getting an NPE in `l.nonEmpty()` for `l`. Now, `getAnnotationArrayValue` returns the error attribute, if that case is detected.
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>   Small fix to let attribution for potential elements pass through

Looks great to me.


Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16977#pullrequestreview-1767342443

More information about the compiler-dev mailing list