RFR: 8320144: Compilation crashes when a custom annotation with invalid default value is used [v5]

Aggelos Biboudis abimpoudis at openjdk.org
Wed Dec 6 13:18:11 UTC 2023


> The erroneous case of:
> 
> `public String[] excludeModules() default new String[0];`
> 
> was not short-circuited in the compiler and we were getting an NPE in `l.nonEmpty()` for `l`. Now, `getAnnotationArrayValue` returns the error attribute, if that case is detected.

Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into fix-#8320144
 - Small fix to let attribution for potential elements pass through
 - Address Jan's review
 - Address review
 - 8320144: Compilation crashes when a custom annotation with invalid default value is used

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16977/files
  - new: https://git.openjdk.org/jdk/pull/16977/files/9922d38e..a79a8473

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16977&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16977&range=03-04

  Stats: 31044 lines in 295 files changed: 8796 ins; 21258 del; 990 mod
  Patch: https://git.openjdk.org/jdk/pull/16977.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16977/head:pull/16977

PR: https://git.openjdk.org/jdk/pull/16977


More information about the compiler-dev mailing list