RFR: 8301813: Bad caret position in error message
Iris Clark
iris at openjdk.org
Mon Feb 6 17:15:52 UTC 2023
On Fri, 3 Feb 2023 22:56:58 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review a trivial update to `DocCommentParser` and corresponding updates to tests, to fix the caret position in the two forms of the "no tag name found" error message.
>
> The fix is simply to use the overload of `erroneous` that allows the preferred caret position to be specified. This overload was not available at the time the affected lines were originally written.
>
> The "natural" place to test this is in the `doctree` tests (that is, `TagTest.java`) but that test is not set up for easy monitoring of the end-user visible caret, so a new doclet test is created for that. (`TestNoTagName.java`).
>
> BadPackageCommentTest.java is also affected. It is updated in a manner similar to that in a parallel PR for handling at-escapes. However, the changed caret position will eventually probably cause a minor change conflict that will need to be resolved.
Marked as reviewed by iris (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/12421
More information about the compiler-dev
mailing list