Integrated: 8301813: Bad caret position in error message

[Jonathan Gibbons]

On Fri, 3 Feb 2023 22:56:58 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial update to `DocCommentParser` and corresponding updates to tests, to fix the caret position in the two forms of the "no tag name found" error message.
> 
> The fix is simply to use the overload of `erroneous` that allows the preferred caret position to be specified. This overload was not available at the time the affected lines were originally written.
> 
> The "natural" place to test this is in the `doctree` tests (that is, `TagTest.java`) but that test is not set up for easy monitoring of the end-user visible caret, so a new doclet test is created for that. (`TestNoTagName.java`).   
> 
> BadPackageCommentTest.java is also affected. It is updated in a manner similar to that in a parallel PR for handling at-escapes. However, the changed caret position will eventually probably cause a minor change conflict that will need to be resolved.

This pull request has now been integrated.

Changeset: d53ade12
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d53ade12a863cc9e9c2bf2528dd0f0f90416f779
Stats:     148 lines in 5 files changed: 134 ins; 6 del; 8 mod

8301813: Bad caret position in error message

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jdk/pull/12421