RFR: 8163229: test test/tools/javac/CaptureInSubtype.java has a main method that is never executed Export [v4]

Vicente Romero vromero at openjdk.org
Fri Jan 6 03:16:50 UTC 2023


On Thu, 5 Jan 2023 21:24:09 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> This PR deals with some housekeeping relating to compiler unit tests.
>> 
>> JDK-8163229 points out that there are several tests that have a `public static void main(String[])` method, but because the test expects to fail during compilation, the test is never actually run, and so these `main` methods are just clutter that can be removed.
>> 
>> However, there are also some tests where the test is never run, but the `main()` method generates one or more of the expected compilation errors. Obviously we need to keep those, but they don't need to be declared as `public static void main(String[])` which is misleading. So instead we rename these methods to `meth()`, and also we remove the `String[]` parameter when it's not needed by the test.
>
> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove two more unnecessary main() methods.

looks good thanks

I have updated the bug title to a more general one, now the PR title need to be synced with it.

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10992


More information about the compiler-dev mailing list