RFR: 8163229: several regression tests have a main method that is never executed [v4]

Julian Waters jwaters at openjdk.org
Tue Jan 17 04:44:09 UTC 2023

On Thu, 5 Jan 2023 21:24:09 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> This PR deals with some housekeeping relating to compiler unit tests.
>> JDK-8163229 points out that there are several tests that have a `public static void main(String[])` method, but because the test expects to fail during compilation, the test is never actually run, and so these `main` methods are just clutter that can be removed.
>> However, there are also some tests where the test is never run, but the `main()` method generates one or more of the expected compilation errors. Obviously we need to keep those, but they don't need to be declared as `public static void main(String[])` which is misleading. So instead we rename these methods to `meth()`, and also we remove the `String[]` parameter when it's not needed by the test.
> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>   Remove two more unnecessary main() methods.

Verified that the test failures are unrelated, will help you sponsor


PR: https://git.openjdk.org/jdk/pull/10992

More information about the compiler-dev mailing list