RFR: JDK-8300857: State return value for Types.asElement(NoType) explicitly [v2]

Jonathan Gibbons jjg at openjdk.org
Wed Jan 25 23:23:17 UTC 2023


On Wed, 25 Jan 2023 03:56:30 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Just sending out the proposed API changes for now, will add tests later.
>> 
>> Please also review the corresponding CSR [JDK-8300951](https://bugs.openjdk.org/browse/JDK-8300951).
>
> Joe Darcy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Applease jcheck.
>  - Refine spec, add regression test.

src/java.compiler/share/classes/javax/lang/model/util/Types.java line 50:

> 48:      * The type may be a {@link DeclaredType} or {@link TypeVariable},
> 49:      * or a pseudo-type for a {@linkplain TypeKind#PACKAGE package} or
> 50:      * {@linkplain TypeKind#MODULE module}.

Commas look erratic.

`The type may be A or B, or C`

-------------

PR: https://git.openjdk.org/jdk/pull/12159


More information about the compiler-dev mailing list