RFR: JDK-8300857: State return value for Types.asElement(NoType) explicitly [v2]

[Jonathan Gibbons]

On Wed, 25 Jan 2023 03:56:30 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Just sending out the proposed API changes for now, will add tests later.
>> 
>> Please also review the corresponding CSR [JDK-8300951](https://bugs.openjdk.org/browse/JDK-8300951).
>
> Joe Darcy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Applease jcheck.
>  - Refine spec, add regression test.

approved with quibbles for optional update

I like the presence of the new test ;-)

test/langtools/tools/javac/processing/model/util/types/TestAsElement.java line 78:

> 76: 
> 77: 
> 78: 

excess blank lines?

test/langtools/tools/javac/processing/model/util/types/TestAsElement.java line 87:

> 85: 
> 86:     private void testRoundTripCases() {
> 87:         expectRoundTrip(eltUtils.getPackageElement("java.lang"));

Maybe add a type element as well as the package element and module element

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12159