RFR: 8296010: AssertionError in annotationTargetType [v2]

[Manu Sridharan]

On Fri, 27 Jan 2023 05:25:49 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> javac is crashing if a class file is forged so that an annotation can be applicable to an unknown target. It would be equivalent to the following declaration:
>> 
>> 
>> @Target({ElementType.FIELD, ElementType.NO_SUCH})
>> @interface A {}
>> 
>> if the compiler process this source it would issue a compiler error, indicating that symbol `NO_SUCH` cant be found. Currently our class reader just issues a warning and move on. This is OK as it could be that the loaded class won't be used anyway but if this annotation is actually applied to symbol as in:
>> 
>> 
>> class B {
>>     @A Object o;
>> }
>> 
>> then this to my understanding should be a compilation error. Currently javac is crashing and this is not acceptable, so this PR is fixing this issue so that a compilation error is issued instead.
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updating parameter name

test/langtools/tools/javac/annotations/crashOnUnknownAttr/CrashOnUnknownTargetTypeTest.java line 10:

> 8: 
> 9: public class CrashOnUnknownTargetTypeTest {
> 10:     @A Object o;

I wonder if it's worth testing the case where the annotation appears on a method as well?  We observed crashes before due to that placement as well.  It's possible the relevant code paths are shared so an additional test is unnecessary

-------------

PR: https://git.openjdk.org/jdk/pull/12241