RFR: 8296010: AssertionError in annotationTargetType [v2]

[Vicente Romero]

On Sat, 28 Jan 2023 17:57:53 GMT, Manu Sridharan <duke at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updating parameter name
>
> test/langtools/tools/javac/annotations/crashOnUnknownAttr/CrashOnUnknownTargetTypeTest.java line 10:
> 
>> 8: 
>> 9: public class CrashOnUnknownTargetTypeTest {
>> 10:     @A Object o;
> 
> I wonder if it's worth testing the case where the annotation appears on a method as well?  We observed crashes before due to that placement as well.  It's possible the relevant code paths are shared so an additional test is unnecessary

@msridhar  thanks for your feedback. Yes we could do that for completeness, probably won't add too much value as the code path is shared, but will take a look at this. Side: did you file any bug on the issue you found? Could you please try this fix on your code base and see if the issue gets fixed? Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12241