RFR: 8312572: JDK 21 RDP2 L10n resource files update
Damon Nguyen
dnguyen at openjdk.org
Thu Jul 27 16:55:51 UTC 2023
On Thu, 27 Jul 2023 06:48:32 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties line 185:
>>
>>> 183: jshell.console.no.javadoc = <no documentation found>
>>> 184: jshell.console.do.nothing = Do nothing
>>> 185: jshell.console.choice = Choice:\u0020
>>
>> I see this backslash is also being removed. It does seem misplaced since none of the other lines use it. But just double checking with you that this is the desired change because for the other locales, the change was to just translate the space to unicode.
>
> Thanks for reviewing Damon, the `` is used to signify the white space after the `:` is intentional. However, using a trailing `\u0020` is more intentional and clear, and allows for consistency between the original and localized versions, so I manually made this change.
Sure, I agree. Just checking to see if this was a product of the translation tool used, because if so, this might've been a mistake or issue with the tool. Looks fine here then
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15047#discussion_r1276566404
More information about the compiler-dev
mailing list