RFR: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled

[Vicente Romero]

On Wed, 7 Jun 2023 21:03:20 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> Hi,
> 
> Please consider this fix for an error handling bug in javac, which causes a deferred diagnostic to be lost when an `Abort` is thrown with annotation processing enabled. See https://bugs.openjdk.org/browse/JDK-8309499 for more details.
> 
> This fix is contributed by my colleague Paula Toth paulatoth at google.com.

Marked as reviewed by vromero (Reviewer).

src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java line 982:

> 980:             // In case an Abort was thrown before processAnnotations could be called,
> 981:             // we could have deferred diagnostics that haven't been reported. At the
> 982:             // time of this comment's writing, this can only ever occur through a

looks good. Suggestion: I would remove the last sentence: `At the time of this comment...` documents an erroneous situation. We usually don't add that type of comments.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14370#pullrequestreview-1469981671
PR Review Comment: https://git.openjdk.org/jdk/pull/14370#discussion_r1223083598