RFR: 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled [v2]

[Liam Miller-Cushon]

On Thu, 8 Jun 2023 13:58:42 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Move deferred diagnostic reporting to catch clause. Remove unnecessary
>>    comment.
>>  - Update a comment as suggested in review
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java line 982:
> 
>> 980:             // In case an Abort was thrown before processAnnotations could be called,
>> 981:             // we could have deferred diagnostics that haven't been reported. At the
>> 982:             // time of this comment's writing, this can only ever occur through a
> 
> looks good. Suggestion: I would remove the last sentence: `At the time of this comment...` documents an erroneous situation. We usually don't add that type of comments.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14370#discussion_r1229791904