RFR: JDK-8303912 - Clean up JavadocTokenizer [v2]

Andrey Turbanov aturbanov at openjdk.org
Fri Mar 17 16:44:29 UTC 2023


On Fri, 17 Mar 2023 16:27:10 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Previous work had cleaned up the JavacTokenizer, but left JavadocTokenizer alone, mostly due to its perplexing state. This is follow up work to simplify the JavadocTokenizer.
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Corrections from review
>  - Merge branch 'master' into 8303912
>  - Clean up JavadocTokenizer

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/UnicodeReader.java line 116:

> 114:      * @param length  length of meaningful content in buffer.
> 115:      */
> 116:     protected  UnicodeReader(Log log, char[] array, int length) {

One space missed :)
Suggestion:

    protected UnicodeReader(Log log, char[] array, int length) {

-------------

PR: https://git.openjdk.org/jdk/pull/12953


More information about the compiler-dev mailing list