RFR: JDK-8303912 - Clean up JavadocTokenizer [v2]

Jonathan Gibbons jjg at openjdk.org
Mon Mar 27 16:55:21 UTC 2023


On Fri, 17 Mar 2023 16:27:10 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Previous work had cleaned up the JavacTokenizer, but left JavadocTokenizer alone, mostly due to its perplexing state. This is follow up work to simplify the JavadocTokenizer.
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Corrections from review
>  - Merge branch 'master' into 8303912
>  - Clean up JavadocTokenizer

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java line 1200:

> 1198:          * LINE starting with //
> 1199:          * BLOCK starting with /*
> 1200:          * JAVADOC starting with /**

The detail here would be better as comments on the enum members.

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java line 1250:

> 1248:          * LINE starting with //
> 1249:          * BLOCK starting with /*
> 1250:          * JAVADOC starting with /**

duplicates info on the decl for `cs`; suggest moving the info to the enum declaration members

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12953#discussion_r1149541782
PR Review Comment: https://git.openjdk.org/jdk/pull/12953#discussion_r1149544294


More information about the compiler-dev mailing list