RFR: 8277501: Revisit PathFileObject.getCharContent and friends [v2]

[Archie L. Cobbs]

On Wed, 29 Mar 2023 21:02:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into JDK-8277501
>>  - Avoid over-reliance on InputStream.available() in BaseFileManager.makeByteBuffer().
>>  - Adjust the semantics of ByteBuffer.appendStream() to not close the stream.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/util/ByteBuffer.java line 62:
> 
>> 60:     }
>> 61: 
>> 62:     /** Create a new byte buffer using the given array for storage.
> 
> Generally, the style for doc comments is either a single line, or for a newline after the initial `/**`

Yeah... except not in this file. I was erring on the side of being consistent with the rest of the file (lesser of two evils?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12755#discussion_r1152570789