RFR: 8277501: Revisit PathFileObject.getCharContent and friends [v2]

Jonathan Gibbons jjg at openjdk.org
Fri Mar 31 23:12:40 UTC 2023


On Wed, 29 Mar 2023 23:01:57 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/util/ByteBuffer.java line 62:
>> 
>>> 60:     }
>>> 61: 
>>> 62:     /** Create a new byte buffer using the given array for storage.
>> 
>> Generally, the style for doc comments is either a single line, or for a newline after the initial `/**`
>
> Yeah... except not in this file. I was erring on the side of being consistent with the rest of the file (lesser of two evils?)

OK, as long as you made a deliberate choice, that's cool.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12755#discussion_r1154986383


More information about the compiler-dev mailing list