RFR: 8288619: Unexpected parsing for @see
Jonathan Gibbons
jjg at openjdk.org
Fri May 12 21:18:43 UTC 2023
On Tue, 9 May 2023 14:01:43 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> When invoking the method `DocCommentParser::quotedString` with field `newline` as `true`
> and the quoted string has the character `@`, `quotedString` will break the loop and return `null`.
> This patch changes the field `newline` to `false` at the beginning of the method `quotedString`
> to solve this issue. And a corresponding test case is added.
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
I see the problem reported in the JBS issue, but the proposed fix is not the best one.
It would be better to set the `newline` flag to false earlier, perhaps at the beginning of `blockTag`
-------------
Changes requested by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13888#pullrequestreview-1425165029
More information about the compiler-dev
mailing list