RFR: 8288619: Unexpected parsing for @see [v3]

Guoxiong Li gli at openjdk.org
Thu May 25 03:29:08 UTC 2023


On Tue, 9 May 2023 14:44:43 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>>> Overall, I would expect `newline` to be set `false`earlier, maybe in `blockTag`, so that the setting applies to all block tags. That might still leave the possibility of a newline happening after the tag name and before the quoted string, but your test case does not cover that.
>> 
>> If there is something between the tag name and the quoted string, 
>> the method `quotedString` is never invoked by method `TagParser::parse`.
>> So such case seems not related to this bug. Do I miss anything?
>
>> > Overall, I would expect `newline` to be set `false`earlier, maybe in `blockTag`, so that the setting applies to all block tags. That might still leave the possibility of a newline happening after the tag name and before the quoted string, but your test case does not cover that.
>> 
>> If there is something between the tag name and the quoted string, the method `quotedString` is never invoked by method `TagParser::parse`. So such case seems not related to this bug. Do I miss anything?
> 
> I was just trying to imagine a case where `newline` might be true after the tag name has been read.

@jonathan-gibbons Thanks for the review. Integrating.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13888#issuecomment-1562203426


More information about the compiler-dev mailing list