RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

Ryan Wallace duke at openjdk.org
Wed Nov 8 09:42:25 UTC 2023


> Hi all,
> 
> Please review this fix for jar tool not producing archive if there is a missing file supplied. Fix is to throw an exception and exit processing when a missing file is supplied. Current behaviour will recognise missing file as an error but continue processing and not produce the archive. Updated ClassPath test to verify jar is not created.
> 
> Thanks,
> Ryan.

Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
 - Merge branch 'master' into 8318971
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16423/files
  - new: https://git.openjdk.org/jdk/pull/16423/files/07553306..612f4c05

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16423&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16423&range=00-01

  Stats: 30476 lines in 738 files changed: 15924 ins; 6266 del; 8286 mod
  Patch: https://git.openjdk.org/jdk/pull/16423.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16423/head:pull/16423

PR: https://git.openjdk.org/jdk/pull/16423


More information about the compiler-dev mailing list