RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

[Jaikiran Pai]

On Wed, 8 Nov 2023 09:42:25 GMT, Ryan Wallace <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for jar tool not producing archive if there is a missing file supplied. Fix is to throw an exception and exit processing when a missing file is supplied. Current behaviour will recognise missing file as an error but continue processing and not produce the archive. Updated ClassPath test to verify jar is not created.
>> 
>> Thanks,
>> Ryan.
>
> Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - Merge branch 'master' into 8318971
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

Thank you Ryan for trying this change. There's one more place in run() where we call this expand() and that happens when we want to update the jar file. (Previously) line 340 is where this call to expand() happens. Can you add a similar check after that call there and see if things continue to work?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1801665250