RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

Ryan Wallace duke at openjdk.org
Wed Nov 8 16:06:20 UTC 2023


On Wed, 8 Nov 2023 09:42:25 GMT, Ryan Wallace <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for jar tool not producing archive if there is a missing file supplied. Fix is to throw an exception and exit processing when a missing file is supplied. Current behaviour will recognise missing file as an error but continue processing and not produce the archive. Updated ClassPath test to verify jar is not created.
>> 
>> Thanks,
>> Ryan.
>
> Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - Merge branch 'master' into 8318971
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

Added and tested and it still works as expected.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1802195024


More information about the compiler-dev mailing list