RFR: 8320001: javac crashes while adding type annotations to the return type of a constructor [v3]

Wed Nov 22 16:22:07 UTC 2023

On Wed, 22 Nov 2023 01:06:35 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Fix for [1] introduced a regression that is making some internal tests fail. Basically fix for [1] is trying to add annotations read from the class file to the corresponding symbol. Constructors are a bit special given that its return type is `void` thus type annotations can't be added to them. This fix is proposing just dropping the type annotation if it applies to the return type of a constructor.
>> 
>> TIA
>> [1] https://bugs.openjdk.org/browse/JDK-8225377
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changing test's summary

Looks reasonable at this time. Thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16774#pullrequestreview-1744858583