RFR: 8320001: javac crashes while adding type annotations to the return type of a constructor [v4]
Vicente Romero
vromero at openjdk.org
Wed Nov 22 21:52:36 UTC 2023
> Fix for [1] introduced a regression that is making some internal tests fail. Basically fix for [1] is trying to add annotations read from the class file to the corresponding symbol. Constructors are a bit special given that its return type is `void` thus type annotations can't be added to them. This fix is proposing just dropping the type annotation if it applies to the return type of a constructor.
>
> TIA
> [1] https://bugs.openjdk.org/browse/JDK-8225377
Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge branch 'master' into JDK-8320001
- changing test's summary
- addressing review comments
- 8320001: javac crashes while adding type annotations to constructor's return type
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16774/files
- new: https://git.openjdk.org/jdk/pull/16774/files/0938db68..990c3d3b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16774&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16774&range=02-03
Stats: 9339 lines in 291 files changed: 6218 ins; 1317 del; 1804 mod
Patch: https://git.openjdk.org/jdk/pull/16774.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16774/head:pull/16774
PR: https://git.openjdk.org/jdk/pull/16774
More information about the compiler-dev
mailing list