RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v43]

Joe Darcy darcy at openjdk.org
Wed Nov 29 20:10:29 UTC 2023


On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Address changes from JEP 445 to JEP 463.
>> 
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>> 
>> - Don't mark class on read.
>> 
>> - Remove reflection and annotation processing related to unnamed classes.
>> 
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update test/jdk/tools/launcher/InstanceMainTest.java
>    
>    Co-authored-by: Jan Lahoda <51319204+lahodaj at users.noreply.github.com>
>  - Update test/jdk/tools/launcher/InstanceMainTest.java
>    
>    Co-authored-by: Jan Lahoda <51319204+lahodaj at users.noreply.github.com>

src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java line 129:

> 127:                 Element enclosing = e.getEnclosingElement();
> 128: 
> 129:                 // Don't print out the constructor of an anonymous

Please add back "class" so that the comment reads "Don't print out the constructor of an anonymous class."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1409810773


More information about the compiler-dev mailing list