RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v43]
Jim Laskey
jlaskey at openjdk.org
Thu Nov 30 12:47:31 UTC 2023
On Wed, 29 Nov 2023 20:07:50 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update test/jdk/tools/launcher/InstanceMainTest.java
>>
>> Co-authored-by: Jan Lahoda <51319204+lahodaj at users.noreply.github.com>
>> - Update test/jdk/tools/launcher/InstanceMainTest.java
>>
>> Co-authored-by: Jan Lahoda <51319204+lahodaj at users.noreply.github.com>
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java line 129:
>
>> 127: Element enclosing = e.getEnclosingElement();
>> 128:
>> 129: // Don't print out the constructor of an anonymous
>
> Please add back "class" so that the comment reads "Don't print out the constructor of an anonymous class."
Done
> test/langtools/tools/javac/processing/model/element/TestImplicitClass.java line 120:
>
>> 118:
>> 119: /*
>> 120: * From JEP 445 JLS changes:
>
> Update JEP number.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1410623183
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1410623324
More information about the compiler-dev
mailing list