RFR: 8313613: Use JUnit in langtools/lib tests

Christian Stein cstein at openjdk.org
Tue Oct 10 04:50:56 UTC 2023

On Mon, 14 Aug 2023 23:57:08 GMT, Qing Xiao <xqoasis at openjdk.org> wrote:

> Use JUnit Jupiter API in langtools/lib tests instead of TestNG. They are under test/langtools/lib/combo/tools/javac/combo/.
> Modified tests that extend tools in CompilationTestCase and JavacTemplateTestBase to implement TestWatcher.

test/langtools/lib/combo/tools/javac/combo/JavacTemplateDiagnosticsPrinter.java line 38:

> 36:  * Class for TestWatcher implementation.
> 37:  */
> 38: public class JavacTemplateDiagnosticPrinter extends JavacTemplateTestBase {

This newly introduced class `JavacTemplateDiagnostic[s]Printer` (including a mismatch in filename and class name) is not used anywhere. Delete it?


PR Review Comment: https://git.openjdk.org/jdk/pull/15281#discussion_r1351439653

More information about the compiler-dev mailing list