RFR: 8313613: Use JUnit in langtools/lib tests
Qing Xiao
xqoasis at openjdk.org
Tue Oct 10 04:57:57 UTC 2023
On Tue, 10 Oct 2023 04:48:05 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Use JUnit Jupiter API in langtools/lib tests instead of TestNG. They are under test/langtools/lib/combo/tools/javac/combo/.
>> Modified tests that extend tools in CompilationTestCase and JavacTemplateTestBase to implement TestWatcher.
>
> test/langtools/lib/combo/tools/javac/combo/JavacTemplateDiagnosticsPrinter.java line 38:
>
>> 36: * Class for TestWatcher implementation.
>> 37: */
>> 38: public class JavacTemplateDiagnosticPrinter extends JavacTemplateTestBase {
>
> This newly introduced class `JavacTemplateDiagnostic[s]Printer` (including a mismatch in filename and class name) is not used anywhere. Delete it?
I see. Sorry for this mistake. I should have deleted it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15281#discussion_r1351443463
More information about the compiler-dev
mailing list