RFR: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util [v6]

[Jonathan Gibbons]

On Wed, 17 Apr 2024 19:58:10 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Provide more concrete discussion of how the preview visitors are expected to evolve for different categories of language changes.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement off-list feedback on HTML id syntax; add trial @see link.

Two minor editorial suggestions

src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 63:

> 61:  *
> 62:  * <li>the preview language construct only triggers the introduction
> 63:  * of a new kind <em>without</em> a new modeling interface.

There are many kinds of kind. Can you qualify which kind you mean here?

src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 242:

> 240:  *        * ENUM_CONSTANT}, {@code EXCEPTION_PARAMETER}, {@code FIELD},
> 241:  *  -     * {@code LOCAL_VARIABLE}, {@code PARAMETER}, or {@code RESOURCE_VARIABLE}.
> 242:  *  +     * {@code LOCAL_VARIABLE}, {@code PARAMETER}, or {@code RESOURCE_VARIABLE},

delete `or` at this position in the list

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18804#pullrequestreview-2010017570
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1571451041
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1571453618