RFR: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util [v6]

[Joe Darcy]

On Thu, 18 Apr 2024 22:20:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement off-list feedback on HTML id syntax; add trial @see link.
>
> src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 63:
> 
>> 61:  *
>> 62:  * <li>the preview language construct only triggers the introduction
>> 63:  * of a new kind <em>without</em> a new modeling interface.
> 
> There are many kinds of kind. Can you qualify which kind you mean here?

Add some more explicit information; thanks for the suggestion.

> src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 242:
> 
>> 240:  *        * ENUM_CONSTANT}, {@code EXCEPTION_PARAMETER}, {@code FIELD},
>> 241:  *  -     * {@code LOCAL_VARIABLE}, {@code PARAMETER}, or {@code RESOURCE_VARIABLE}.
>> 242:  *  +     * {@code LOCAL_VARIABLE}, {@code PARAMETER}, or {@code RESOURCE_VARIABLE},
> 
> delete `or` at this position in the list

Fixed; thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1571554258
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1571554092