RFR: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp

[Jonathan Gibbons]

On Wed, 24 Apr 2024 16:52:44 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change that now uses a source generator and compiler task to verify no SOE is thrown.
> 
> This change replaces over 1000 lines of code that were being compiled by running this test as well as other tests crawling over test files. Some of those crawling tests failed to parse this formerly large file. The new size of this test file should be no problem for them.
> 
> The level of nesting is increased from 567 to 1000.

test/langtools/tools/javac/patterns/SOEDeeplyNestedBlocksTest.java line 42:

> 40:         lines.add("class Test {");
> 41:         lines.add("  static { ");
> 42:         for (int i = 0; i < 1000; i++) lines.add("    synchronized (Test.class) {");

Suggest using a  named constant  for the two values of 1000

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18939#discussion_r1578339343