RFR: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp [v2]
Christian Stein
cstein at openjdk.org
Wed Apr 24 18:42:42 UTC 2024
On Wed, 24 Apr 2024 18:27:29 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Introduce constant for the depth of nesting levels
>
> test/langtools/tools/javac/patterns/SOEDeeplyNestedBlocksTest.java line 42:
>
>> 40: lines.add("class Test {");
>> 41: lines.add(" static { ");
>> 42: for (int i = 0; i < 1000; i++) lines.add(" synchronized (Test.class) {");
>
> Suggest using a named constant for the two instances of 1000
Done via https://github.com/openjdk/jdk/pull/18939/commits/6d51348f5edfa1586ae3255539bdb1a0f156d3ca
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18939#discussion_r1578352285
More information about the compiler-dev
mailing list