RFR: 8337851: Some tests have name which confuse jtreg [v3]
toshiogata
duke at openjdk.org
Mon Aug 19 01:39:54 UTC 2024
On Fri, 16 Aug 2024 11:40:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> As you mentioned, it's a good time to make a minor improvement, so I modified the test.
>
> I propose not to edit the renamed files.
>
> First of all, the purpose of this PR is to *rename tests* to workaround a _misfeature_ of jtreg.
>
> Git does not support renames natively, therefore by editing the renamed files you could break Git ability to detect renaming.
>
> Additionally, these tests are not part of client and I am not aware of the practices in Java Compiler team. Expanding wildcard imports should be fine, yet I would rather avoid editing the renamed files as I mentioned above.
Thank you for pointing it out. I was not aware of the git rename issue.
I changed the fix to only rename files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1721122162
More information about the compiler-dev
mailing list