RFR: 8337851: Some tests have name which confuse jtreg [v3]
Jonathan Gibbons
jjg at openjdk.org
Fri Aug 23 22:17:04 UTC 2024
On Mon, 19 Aug 2024 12:34:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Thank you for pointing it out. I was not aware of the git rename issue.
>> I changed the fix to only rename files.
>
>> Thank you for pointing it out. I was not aware of the git rename issue.
>
> Even if it were not for this Git “limitation”, I still think additional changes should be requested by Java Compiler team. I am not aware of their practices.
>
> @alisenchung knows I'm advocating for expanding imports (whenever a test or source file is modified) and for moving jtreg tags below imports closer to the class declaration. At the same time, we haven't reached an agreement about it, although some people seem to support it too.
With my official `jtreg` hat on, I recommend always placing the `jtreg` tags immediately after any legal header comments and _before_ any of the source code that comprises the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1729563721
More information about the compiler-dev
mailing list