RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Tue Dec 10 19:40:38 UTC 2024
On Tue, 10 Dec 2024 19:35:21 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the correctness on the quality of the translations themselves.
>>
>> Generally speaking, observed differences in punctuation can be attributed to language rules. Any keys requiring localization that came in after the JDK was submitted for translations will be handled in the RDP2 L10n drop.
>
> Justin Lu has updated the pull request incrementally with four additional commits since the last revision:
>
> - implement Severin's review
>
> Co-authored-by: Severin Gehwolf <jerboaa at gmail.com>
> - implement Jan's review
> - implement Henry's review
> - implement Weijun's review
jlink l10n update looks fine.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22588#pullrequestreview-2493399735
More information about the compiler-dev
mailing list