RFR: JDK-8325687: SimpleJavaFileObject specification would benefit from implSpec [v2]
ExE Boss
duke at openjdk.org
Fri Feb 16 15:35:54 UTC 2024
On Thu, 15 Feb 2024 21:22:07 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> While reading the spec in the context of another potential change, noticed some cases where using implSpec would lead to a better structured specification.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>
> Implement review feedback.
src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java line 107:
> 105: * @implSpec
> 106: * This implementation wraps the result of {@linkplain
> 107: * #getCharContent} in a {@link Reader}.
Suggestion:
* This implementation wraps the result of {@linkplain #getCharContent}
* in a {@link Reader}.
src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java line 141:
> 139: * @implSpec
> 140: * This implementation wraps the result of {@link
> 141: * openOutputStream} in a {@link Writer}.
Suggestion:
* This implementation wraps the result of {@linkplain #openOutputStream}
* in a {@link Writer}.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17854#discussion_r1492643539
PR Review Comment: https://git.openjdk.org/jdk/pull/17854#discussion_r1492644828
More information about the compiler-dev
mailing list