RFR: JDK-8325687: SimpleJavaFileObject specification would benefit from implSpec [v2]

ExE Boss duke at openjdk.org
Fri Feb 16 22:05:53 UTC 2024


On Fri, 16 Feb 2024 15:32:30 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement review feedback.
>
> src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java line 141:
> 
>> 139:      * @implSpec
>> 140:      * This implementation wraps the result of {@link
>> 141:      * openOutputStream} in a {@link Writer}.
> 
> Suggestion:
> 
>      * This implementation wraps the result of {@linkplain #openOutputStream}
>      * in a {@link Writer}.

Still missing the `#` to make a valid link:
Suggestion:

     * This implementation wraps the result of {@link #openOutputStream}
     * in a {@link Writer}.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17854#discussion_r1493023829


More information about the compiler-dev mailing list