RFR: JDK-8325687: SimpleJavaFileObject specification would benefit from implSpec [v2]

Joe Darcy darcy at openjdk.org
Fri Feb 16 22:55:04 UTC 2024


On Fri, 16 Feb 2024 22:02:55 GMT, ExE Boss <duke at openjdk.org> wrote:

>> src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java line 141:
>> 
>>> 139:      * @implSpec
>>> 140:      * This implementation wraps the result of {@link
>>> 141:      * openOutputStream} in a {@link Writer}.
>> 
>> Suggestion:
>> 
>>      * This implementation wraps the result of {@linkplain #openOutputStream}
>>      * in a {@link Writer}.
>
> Still missing the `#` to make a valid link:
> Suggestion:
> 
>      * This implementation wraps the result of {@link #openOutputStream}
>      * in a {@link Writer}.

Hmm. Well, the build and docs build succeed with the `#` and produce a link in the generated HTML, but I'll add it before pushing. Thanks,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17854#discussion_r1493052787


More information about the compiler-dev mailing list