RFR: JDK-8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results [v2]

Jonathan Gibbons jjg at openjdk.org
Thu Jan 18 00:13:27 UTC 2024


On Thu, 18 Jan 2024 00:03:59 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java line 92:
>> 
>>> 90:     PrintWriter out;
>>> 91:     boolean verbose = true;
>>> 92:     static Map<String, Class<? extends Annotation>> nameToAnnotation;
>> 
>> this looks questionable ... a mutable static field
>
> Good point -- the mapping should be static given the method it is used in are static; I'll change to a static final. Thanks.

is it possible to make this static final with an initializer?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17410#discussion_r1456643600


More information about the compiler-dev mailing list