RFR: JDK-8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results [v3]

[Joe Darcy]

On Thu, 18 Jan 2024 00:09:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement review feedback on regression test.
>
> test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java line 115:
> 
>> 113:                           new NameToAnnotationEntry("BasicAnnoTests.TB",   BasicAnnoTests.TB.class),
>> 114:                           new NameToAnnotationEntry("BasicAnnoTests.TC",   BasicAnnoTests.TC.class),
>> 115:                           new NameToAnnotationEntry("BasicAnnoTests.TCs",  BasicAnnoTests.TCs.class));
> 
> You could maybe simplify this by obtaining the name from the class parameter.

Might be a case a premature optimization, but I wanted to avoid the repeated reflective operations here.

> test/langtools/tools/javac/processing/model/type/BasicAnnoTests.java line 318:
> 
>> 316:     /**
>> 317:      * Verify that an annotation mirror returned by
>> 318:      * getAnnotatinMirrors() has a matching annotation from
> 
> spelling typo: getAnnotatinMirrors

Fixed; thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17410#discussion_r1456669422
PR Review Comment: https://git.openjdk.org/jdk/pull/17410#discussion_r1456669060