RFR: JDK-8175386: Clarify exception behavior of Types utility methods [v4]

[Jonathan Gibbons]

On Fri, 26 Jan 2024 21:02:53 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Incremental improvements and clarifications in the specification of Types.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8175386
>  - Implement review feedback.
>  - Fix typo found in code review.
>  - JDK-8175386: Clarify exception behavior of Types utility methods

Marked as reviewed by jjg (Reviewer).

src/java.compiler/share/classes/javax/lang/model/util/Types.java line 48:

> 46:  * methods. One or more out of scope arguments will typically result
> 47:  * in a method throwing an {@link IllegalArgumentException
> 48:  * IllegalArgumentException}.

Nit: do you need the second argument? It should be the default string.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17523#pullrequestreview-1846568129
PR Review Comment: https://git.openjdk.org/jdk/pull/17523#discussion_r1468158159