RFR: JDK-8175386: Clarify exception behavior of Types utility methods [v4]

Joe Darcy darcy at openjdk.org
Fri Jan 26 21:54:33 UTC 2024


On Fri, 26 Jan 2024 21:21:06 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8175386
>>  - Implement review feedback.
>>  - Fix typo found in code review.
>>  - JDK-8175386: Clarify exception behavior of Types utility methods
>
> src/java.compiler/share/classes/javax/lang/model/util/Types.java line 48:
> 
>> 46:  * methods. One or more out of scope arguments will typically result
>> 47:  * in a method throwing an {@link IllegalArgumentException
>> 48:  * IllegalArgumentException}.
> 
> Nit: do you need the second argument? It should be the default string.

I'll check if "java.lang" is inserted without the second argument.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17523#discussion_r1468181148


More information about the compiler-dev mailing list