RFR: 8332474: Tighten up ToolBox' JavacTask to not silently accept javac crash as a failure [v2]
Jan Lahoda
jlahoda at openjdk.org
Tue Jul 2 12:59:31 UTC 2024
On Mon, 1 Jul 2024 18:22:15 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixing typo, as suggested.
>
> test/langtools/tools/lib/toolbox/AbstractTask.java line 94:
>
>> 92: * @param exitCodeValidator an exit code validator. The first parameter will
>> 93: * be the actual exit code, the second test name,
>> 94: * should throw TaskError is the exit code is not
>
> typo: "is the exit code" -> "if the exit code"
Thanks, fixed now!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19972#discussion_r1662468630
More information about the compiler-dev
mailing list