RFR: 8332474: Tighten up ToolBox' JavacTask to not silently accept javac crash as a failure [v2]

[Jan Lahoda]

On Mon, 1 Jul 2024 18:24:18 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing typo, as suggested.
>
> test/langtools/tools/lib/toolbox/JavacTask.java line 331:
> 
>> 329:     @Override
>> 330:     public Result run(Expect expect, int exitCode) {
>> 331:         if (exitCode == 4) {
> 
> I guess we never expect `javac` to crash, and should not be able to test that it does, right?

I am not too worried about a test that would intentionally crash javac, and would need to test for that. It is not clear to me what would be the purpose of the test. And, assuming this need would indeed be rare, there are other ways to test for that. So, I opted for a more strict approach. OTOH, I don't have a too strong opinion on this, so I can re-allow exit code 4 here if desired.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19972#discussion_r1662486180