RFR: 8336470: Source launcher should work with service loader SPI in unnamed module [v4]

Jaikiran Pai jpai at openjdk.org
Fri Jul 19 15:22:31 UTC 2024


On Fri, 19 Jul 2024 06:36:03 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change adding a missing resource file test to the `MemoryClassLoader::findResource` override in order to resolve all files beneath the source root path in source launch mode - analog to what was already implemented for `MemoryClassLoader::getResource`.
>> 
>> With this change applied, files in `META-INF/services/` are resolved; allowing services providers being supplied in source form.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixup line endings

test/langtools/tools/javac/launcher/src/Tool.java line 8:

> 6:  * under the terms of the GNU General Public License version 2 only, as
> 7:  * published by the Free Software Foundation.  Oracle designates this
> 8:  * particular file as subject to the "Classpath" exception as provided

A test file isn't expected to use this "Classpath" exception copyright text. The copyright text from some other existing test file can be borrowed here to fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20193#discussion_r1684536583


More information about the compiler-dev mailing list