RFR: 8336470: Source launcher should work with service loader SPI in unnamed module [v4]

[Christian Stein]

On Fri, 19 Jul 2024 15:12:20 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixup line endings
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/MemoryClassLoader.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Hello Christian, this should be `2023, 2024, `

Good catch, will fix it.

> test/langtools/tools/javac/launcher/src/Tool.java line 8:
> 
>> 6:  * under the terms of the GNU General Public License version 2 only, as
>> 7:  * published by the Free Software Foundation.  Oracle designates this
>> 8:  * particular file as subject to the "Classpath" exception as provided
> 
> A test file isn't expected to use this "Classpath" exception copyright text. The copyright text from some other existing test file can be borrowed here to fix it.

Will fix this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20193#discussion_r1685521001
PR Review Comment: https://git.openjdk.org/jdk/pull/20193#discussion_r1685521048