RFR: 8323605: Java source launcher should not require `--source ...` to enable preview [v4]

Christian Stein cstein at openjdk.org
Mon Mar 4 08:18:25 UTC 2024


> Please review this PR targeting the source launcher that instead of throwing an error reading _"--enable-preview must be used with --source"_ adds the required compiler arguments on-the-fly.
> 
> The add arguments are `--release` and `feature`, with `feature` being the release feature number of the current Java runtime as acquired by `Runtime.version().feature()`.

Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Update `java`'s man page
 - Merge branch 'refs/heads/master' into JDK-8323605-launch-with-source-by-default
 - Remove now outdated workaround
   
   [skip ci]
 - Update copyright dates
   
   [skip ci]
 - 8323605: Java source launcher should not require `--source ...` to enable preview

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17731/files
  - new: https://git.openjdk.org/jdk/pull/17731/files/23fba2bf..bb8eac9a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17731&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17731&range=02-03

  Stats: 48207 lines in 2199 files changed: 22996 ins; 14625 del; 10586 mod
  Patch: https://git.openjdk.org/jdk/pull/17731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17731/head:pull/17731

PR: https://git.openjdk.org/jdk/pull/17731


More information about the compiler-dev mailing list